Skip to content

[CHIA-3654] [CHIA-3537] [CHIA-3673] stub chiapos2 API #19969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 3, 2025
Merged

[CHIA-3654] [CHIA-3537] [CHIA-3673] stub chiapos2 API #19969

merged 3 commits into from
Sep 3, 2025

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 19, 2025 •
edited
Loading

Purpose:

unlock integrating chiapos2/v2 plot support in chia-blockchain. These function stubs will be implemented by the chiapos2 library.

The new name for "plot difficulty" is "plot strength".

@arvidn arvidn force-pushed the chiapos2-stubs branch 2 times, most recently from 3da5963 to 0599a3a Compare August 19, 2025 13:37
@arvidn arvidn added Added Required label for PR that categorizes merge commit message as "Added" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Aug 19, 2025
@arvidn arvidn requested a review from almogdepaz August 19, 2025 13:38
@arvidn arvidn changed the title stub chiapos2 API [CHIA-3520] stub chiapos2 API Aug 19, 2025
@arvidn arvidn marked this pull request as ready for review August 19, 2025 14:28
@arvidn arvidn requested a review from a team as a code owner August 19, 2025 14:28
@arvidn arvidn marked this pull request as draft August 19, 2025 14:34
@arvidn arvidn marked this pull request as ready for review August 19, 2025 14:56
@arvidn arvidn mentioned this pull request Aug 19, 2025
Merged
almogdepaz
almogdepaz reviewed Aug 19, 2025
View reviewed changes
almogdepaz
almogdepaz reviewed Aug 19, 2025
View reviewed changes
@arvidn arvidn requested a review from altendky as a code owner August 20, 2025 07:20
@arvidn arvidn marked this pull request as draft August 20, 2025 07:20
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 20, 2025
@arvidn arvidn force-pushed the chiapos2-stubs branch 2 times, most recently from 0fe27a3 to d251b8e Compare August 20, 2025 10:23
@arvidn arvidn mentioned this pull request Aug 21, 2025
Merged
@arvidn arvidn changed the title [CHIA-3520] stub chiapos2 API [CHIA-3654] stub chiapos2 API Aug 22, 2025
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main labels Aug 22, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Aug 22, 2025
@arvidn arvidn marked this pull request as ready for review August 22, 2025 22:41
almogdepaz
almogdepaz reviewed Aug 24, 2025
View reviewed changes
@arvidn arvidn requested a review from almogdepaz August 25, 2025 13:12
almogdepaz
almogdepaz reviewed Sep 2, 2025
View reviewed changes
almogdepaz
almogdepaz reviewed Sep 2, 2025
View reviewed changes
almogdepaz
almogdepaz reviewed Sep 2, 2025
View reviewed changes
almogdepaz
almogdepaz reviewed Sep 2, 2025
View reviewed changes
almogdepaz
almogdepaz approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@almogdepaz almogdepaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arvidn arvidn requested a review from wjblanke September 2, 2025 13:08
@arvidn arvidn closed this Sep 2, 2025
@arvidn arvidn reopened this Sep 2, 2025
@danieljperry danieljperry changed the title [CHIA-3654] stub chiapos2 API [CHIA-3654] [CHIA-3537] stub chiapos2 API Sep 3, 2025
@danieljperry danieljperry changed the title [CHIA-3654] [CHIA-3537] stub chiapos2 API [CHIA-3654] [CHIA-3537] [CHIA-3683] stub chiapos2 API Sep 3, 2025
@danieljperry danieljperry changed the title [CHIA-3654] [CHIA-3537] [CHIA-3683] stub chiapos2 API [CHIA-3654] [CHIA-3537] [CHIA-3673] stub chiapos2 API Sep 3, 2025
wjblanke
wjblanke approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

File Coverage Missing Lines
chia/harvester/harvester_api.py 50.0% lines 171
chia/plotting/prover.py 80.0% lines 128
chia/simulator/block_tools.py 76.5% lines 1523, 1533, 1537, 1557
chia/solver/solver.py 20.0% lines 71-74
chia/types/blockchain_format/proof_of_space.py 77.8% lines 30, 36
Total Missing Coverage
44 lines 12 lines 72%

@arvidn arvidn added ready_to_merge Submitter and reviewers think this is ready and removed coverage-diff labels Sep 3, 2025
@pmaslana pmaslana merged commit e4961d9 into main Sep 3, 2025
1058 of 1067 checks passed
@pmaslana pmaslana deleted the chiapos2-stubs branch September 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@almogdepaz almogdepaz almogdepaz approved these changes

@altendky altendky Awaiting requested review from altendky

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvidn @wjblanke @almogdepaz @pmaslana